Closed
Conversation
ipapandinas
added
shiden
Contributor
|
@ipapandinas why is a new release needed? |
Contributor
Author
|
@Dinonard Not really needed, just to make it cleaner and I've not prepared the Astar preimage yet for the runtime upgrade. So we could take advantage of that, but it can wait and be included later with the follow-up clean-up. |
Contributor
|
I'd suggest not to do it, and use the same code/logic that has been tested on Shibuya/Shiden. |
Minimum allowed line rate is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Summary
This PR prepares runtime 2102 release to include #1595